From 5fb1e841eb26f6223504e46dacfc40c2e510f72d Mon Sep 17 00:00:00 2001 From: Oliver McFadden Date: Tue, 20 Apr 2010 06:59:58 +0300 Subject: evdev: EvdevProbe: check ioctl() return value and warn on failure. Called function "ioctl" whose return value should be checked (checked 10 out of 11 times) Signed-off-by: Oliver McFadden Reviewed-by: Peter Hutterer --- src/evdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 6992c68..ccea90d 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -1782,8 +1782,9 @@ EvdevProbe(InputInfoPtr pInfo) xf86Msg(X_ERROR, "Grab failed. Device already configured?\n"); return 1; } - } else if (pEvdev->grabDevice) { - ioctl(pInfo->fd, EVIOCGRAB, (void *)0); + } else if (pEvdev->grabDevice && ioctl(pInfo->fd, EVIOCGRAB, (void *)0)) { + xf86Msg(X_WARNING, "%s: Release failed (%s)\n", pInfo->name, + strerror(errno)); } /* Trinary state for ignoring axes: -- cgit v1.2.3