diff options
author | dakkar <dakkar@thenautilus.net> | 2017-02-07 19:23:15 +0000 |
---|---|---|
committer | dakkar <dakkar@thenautilus.net> | 2017-02-07 19:23:15 +0000 |
commit | 64113856c246f354cc5f9660733bcf28692c4b30 (patch) | |
tree | eab8a0bce0de1597e0ea4a5222fd3fd3238a9186 | |
parent | don't critique Moo's builders (diff) | |
download | Sietima-64113856c246f354cc5f9660733bcf28692c4b30.tar.gz Sietima-64113856c246f354cc5f9660733bcf28692c4b30.tar.bz2 Sietima-64113856c246f354cc5f9660733bcf28692c4b30.zip |
Perl::Critic test passes now
-rw-r--r-- | lib/Sietima.pm | 2 | ||||
-rw-r--r-- | lib/Sietima/MailStore/FS.pm | 3 | ||||
-rw-r--r-- | lib/Sietima/Role/SubscriberOnly.pm | 2 | ||||
-rw-r--r-- | lib/Sietima/Types.pm | 5 | ||||
-rw-r--r-- | perlcritic.rc | 5 |
5 files changed, 11 insertions, 6 deletions
diff --git a/lib/Sietima.pm b/lib/Sietima.pm index 7d74ab5..b40e9fc 100644 --- a/lib/Sietima.pm +++ b/lib/Sietima.pm @@ -263,7 +263,7 @@ sub send_message($self,$outgoing_message) { return; } -sub _trait_namespace { 'Sietima::Role' } +sub _trait_namespace { 'Sietima::Role' } ## no critic(ProhibitUnusedPrivateSubroutines) =head2 C<list_addresses> diff --git a/lib/Sietima/MailStore/FS.pm b/lib/Sietima/MailStore/FS.pm index e4dfc4d..adc1c03 100644 --- a/lib/Sietima/MailStore/FS.pm +++ b/lib/Sietima/MailStore/FS.pm @@ -8,6 +8,9 @@ use Sietima::Types qw(EmailMIME TagName); use Digest::SHA qw(sha1_hex); use namespace::clean; +# VERSION +# ABSTRACT: filesystem-backed email store + with 'Sietima::MailStore'; has root => ( diff --git a/lib/Sietima/Role/SubscriberOnly.pm b/lib/Sietima/Role/SubscriberOnly.pm index d9d9ac5..d2edf6b 100644 --- a/lib/Sietima/Role/SubscriberOnly.pm +++ b/lib/Sietima/Role/SubscriberOnly.pm @@ -46,7 +46,7 @@ list. requires 'munge_mail_from_non_subscriber'; -our $let_it_pass=0; +our $let_it_pass=0; ## no critic(ProhibitPackageVars) =head1 MODIFIED METHODS diff --git a/lib/Sietima/Types.pm b/lib/Sietima/Types.pm index 1073ddb..e7a576d 100644 --- a/lib/Sietima/Types.pm +++ b/lib/Sietima/Types.pm @@ -76,9 +76,8 @@ role_type MailStore, { role => 'Sietima::MailStore' }; declare_coercion MailStoreFromHashRef, to_type MailStore, from HashRef, - q{ require Module::Runtime; - Module::Runtime::use_module(delete $_->{class})->new($_); - }; + q{ require Module::Runtime; } . + q{ Module::Runtime::use_module(delete $_->{class})->new($_); }; =head2 C<Address> diff --git a/perlcritic.rc b/perlcritic.rc index e8d987d..f060909 100644 --- a/perlcritic.rc +++ b/perlcritic.rc @@ -243,8 +243,9 @@ allow_import_of = utf8 strict warnings # Values that are always included: new. # forbid = +# postderef confuses this # Write `@{ $array_ref }' instead of `@$array_ref'. -[References::ProhibitDoubleSigils] +[-References::ProhibitDoubleSigils] # Capture variable used outside conditional. [RegularExpressions::ProhibitCaptureWithoutTest] @@ -353,9 +354,11 @@ statements = 10 # Always `use strict'. [TestingAndDebugging::RequireUseStrict] +equivalent_modules = Sietima::Policy # Always `use warnings'. [TestingAndDebugging::RequireUseWarnings] +equivalent_modules = Sietima::Policy # Don't use the comma operator as a statement separator. [ValuesAndExpressions::ProhibitCommaSeparatedStatements] |