From 64113856c246f354cc5f9660733bcf28692c4b30 Mon Sep 17 00:00:00 2001 From: dakkar Date: Tue, 7 Feb 2017 19:23:15 +0000 Subject: Perl::Critic test passes now --- lib/Sietima.pm | 2 +- lib/Sietima/MailStore/FS.pm | 3 +++ lib/Sietima/Role/SubscriberOnly.pm | 2 +- lib/Sietima/Types.pm | 5 ++--- 4 files changed, 7 insertions(+), 5 deletions(-) (limited to 'lib') diff --git a/lib/Sietima.pm b/lib/Sietima.pm index 7d74ab5..b40e9fc 100644 --- a/lib/Sietima.pm +++ b/lib/Sietima.pm @@ -263,7 +263,7 @@ sub send_message($self,$outgoing_message) { return; } -sub _trait_namespace { 'Sietima::Role' } +sub _trait_namespace { 'Sietima::Role' } ## no critic(ProhibitUnusedPrivateSubroutines) =head2 C diff --git a/lib/Sietima/MailStore/FS.pm b/lib/Sietima/MailStore/FS.pm index e4dfc4d..adc1c03 100644 --- a/lib/Sietima/MailStore/FS.pm +++ b/lib/Sietima/MailStore/FS.pm @@ -8,6 +8,9 @@ use Sietima::Types qw(EmailMIME TagName); use Digest::SHA qw(sha1_hex); use namespace::clean; +# VERSION +# ABSTRACT: filesystem-backed email store + with 'Sietima::MailStore'; has root => ( diff --git a/lib/Sietima/Role/SubscriberOnly.pm b/lib/Sietima/Role/SubscriberOnly.pm index d9d9ac5..d2edf6b 100644 --- a/lib/Sietima/Role/SubscriberOnly.pm +++ b/lib/Sietima/Role/SubscriberOnly.pm @@ -46,7 +46,7 @@ list. requires 'munge_mail_from_non_subscriber'; -our $let_it_pass=0; +our $let_it_pass=0; ## no critic(ProhibitPackageVars) =head1 MODIFIED METHODS diff --git a/lib/Sietima/Types.pm b/lib/Sietima/Types.pm index 1073ddb..e7a576d 100644 --- a/lib/Sietima/Types.pm +++ b/lib/Sietima/Types.pm @@ -76,9 +76,8 @@ role_type MailStore, { role => 'Sietima::MailStore' }; declare_coercion MailStoreFromHashRef, to_type MailStore, from HashRef, - q{ require Module::Runtime; - Module::Runtime::use_module(delete $_->{class})->new($_); - }; + q{ require Module::Runtime; } . + q{ Module::Runtime::use_module(delete $_->{class})->new($_); }; =head2 C
-- cgit v1.2.3