From ffb0397721a50682b2fc54f53ea6bf94937b21c8 Mon Sep 17 00:00:00 2001 From: dakkar Date: Thu, 16 Apr 2009 22:12:47 +0200 Subject: documentation, and a few author-tests --- Makefile.PL | 2 ++ 1 file changed, 2 insertions(+) (limited to 'Makefile.PL') diff --git a/Makefile.PL b/Makefile.PL index 5f0c3d4..8912266 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -6,9 +6,11 @@ all_from 'lib/Tree/Transform/XSLTish.pm'; requires 'Tree::XPathEngine' => 0, 'Moose' => 0, + 'Class::MOP' => 0, 'Params::Validate' => 0, 'Carp::Clan' => 0, 'Sub::Exporter' => 0, + 'MooseX::AttributeHelpers' => 0, ; test_requires 'Test::Most' => 0, -- cgit v1.2.3 From 1f9c8426a9bf1c94a6cf00edd85628d1c09e22e0 Mon Sep 17 00:00:00 2001 From: Gianni Ceccarelli Date: Thu, 23 Apr 2009 15:04:07 +0200 Subject: new tests --- Makefile.PL | 1 + t/00-author-critic.t | 33 +++++++++++++++++++++++++++++++++ t/00-author-deps.t | 6 ------ t/00-author-minver.t | 33 +++++++++++++++++++++++++++++++++ t/00-author-pod-cover.t | 7 ------- t/00-author-pod.t | 35 +++++++++++++++++++++++++++++++---- 6 files changed, 98 insertions(+), 17 deletions(-) create mode 100644 t/00-author-critic.t delete mode 100644 t/00-author-deps.t create mode 100644 t/00-author-minver.t delete mode 100644 t/00-author-pod-cover.t (limited to 'Makefile.PL') diff --git a/Makefile.PL b/Makefile.PL index 8912266..1971a86 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -11,6 +11,7 @@ requires 'Tree::XPathEngine' => 0, 'Carp::Clan' => 0, 'Sub::Exporter' => 0, 'MooseX::AttributeHelpers' => 0, + 'perl' => '5.6.0', ; test_requires 'Test::Most' => 0, diff --git a/t/00-author-critic.t b/t/00-author-critic.t new file mode 100644 index 0000000..d0a133a --- /dev/null +++ b/t/00-author-critic.t @@ -0,0 +1,33 @@ +#!/usr/bin/perl + +# Test that the module passes perlcritic +use strict; +BEGIN { + $| = 1; + $^W = 1; +} + +my @MODULES = ( + 'Perl::Critic 1.098', + 'Test::Perl::Critic 1.01', +); + +# Don't run tests during end-user installs +use Test::More; +unless ( $ENV{AUTOMATED_TESTING} or $ENV{RELEASE_TESTING} ) { + plan( skip_all => "Author tests not required for installation" ); +} + +# Load the testing modules +foreach my $MODULE ( @MODULES ) { + eval "use $MODULE"; + if ( $@ ) { + $ENV{RELEASE_TESTING} + ? die( "Failed to load required release-testing module $MODULE" ) + : plan( skip_all => "$MODULE not available for testing" ); + } +} +Test::Perl::Critic->import( -exclude => ['ProhibitSubroutinePrototypes']); +all_critic_ok(); + +1; diff --git a/t/00-author-deps.t b/t/00-author-deps.t deleted file mode 100644 index f92ec06..0000000 --- a/t/00-author-deps.t +++ /dev/null @@ -1,6 +0,0 @@ -#!perl -use Test::Most; -plan skip_all => "skipping author-only test" unless $ENV{RUN_AUTHOR_TESTS}; -eval "use Test::Dependencies exclude => [qw(Tree::Transform::XSLTish XML::LibXML Moose::Util::TypeConstraints)]"; - -ok_dependencies(); diff --git a/t/00-author-minver.t b/t/00-author-minver.t new file mode 100644 index 0000000..4dfb876 --- /dev/null +++ b/t/00-author-minver.t @@ -0,0 +1,33 @@ +#!/usr/bin/perl + +# Test that our declared minimum Perl version matches our syntax +use strict; +BEGIN { + $| = 1; + $^W = 1; +} + +my @MODULES = ( + 'Perl::MinimumVersion 1.20', + 'Test::MinimumVersion 0.008', +); + +# Don't run tests during end-user installs +use Test::More; +unless ( $ENV{AUTOMATED_TESTING} or $ENV{RELEASE_TESTING} ) { + plan( skip_all => "Author tests not required for installation" ); +} + +# Load the testing modules +foreach my $MODULE ( @MODULES ) { + eval "use $MODULE"; + if ( $@ ) { + $ENV{RELEASE_TESTING} + ? die( "Failed to load required release-testing module $MODULE" ) + : plan( skip_all => "$MODULE not available for testing" ); + } +} + +all_minimum_version_from_metayml_ok(); + +1; diff --git a/t/00-author-pod-cover.t b/t/00-author-pod-cover.t deleted file mode 100644 index 9bace3e..0000000 --- a/t/00-author-pod-cover.t +++ /dev/null @@ -1,7 +0,0 @@ -#!perl -use Test::Most; -plan skip_all => "skipping author-only test" unless $ENV{RUN_AUTHOR_TESTS}; -eval "use Test::Pod::Coverage"; -all_pod_coverage_ok({ - trustme=> [qr(^new_transformer$)], -}); diff --git a/t/00-author-pod.t b/t/00-author-pod.t index 5177b0c..2cdfcc4 100644 --- a/t/00-author-pod.t +++ b/t/00-author-pod.t @@ -1,6 +1,33 @@ -#!perl -use Test::Most; -plan skip_all => "skipping author-only test" unless $ENV{RUN_AUTHOR_TESTS}; -eval "use Test::Pod"; +#!/usr/bin/perl + +# Test that the syntax of our POD documentation is valid +use strict; +BEGIN { + $| = 1; + $^W = 1; +} + +my @MODULES = ( + 'Pod::Simple 3.07', + 'Test::Pod 1.26', +); + +# Don't run tests during end-user installs +use Test::More; +unless ( $ENV{AUTOMATED_TESTING} or $ENV{RELEASE_TESTING} ) { + plan( skip_all => "Author tests not required for installation" ); +} + +# Load the testing modules +foreach my $MODULE ( @MODULES ) { + eval "use $MODULE"; + if ( $@ ) { + $ENV{RELEASE_TESTING} + ? die( "Failed to load required release-testing module $MODULE" ) + : plan( skip_all => "$MODULE not available for testing" ); + } +} all_pod_files_ok(); + +1; -- cgit v1.2.3 From de1a2f95f3ff6cf1d09e0f4df10f4c5e1c67aead Mon Sep 17 00:00:00 2001 From: dakkar Date: Sat, 25 Apr 2009 09:42:27 +0200 Subject: updated dependencies, removed work-arounds --- Makefile.PL | 2 +- t/01-basic.t | 3 --- t/02-inherit.t | 3 --- t/03-byname.t | 3 --- t/04-errors.t | 3 --- t/05-html-tree.t | 6 ++---- t/perlcriticrc | 1 + 7 files changed, 4 insertions(+), 17 deletions(-) (limited to 'Makefile.PL') diff --git a/Makefile.PL b/Makefile.PL index 1971a86..d387a46 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -15,7 +15,7 @@ requires 'Tree::XPathEngine' => 0, ; test_requires 'Test::Most' => 0, - 'Tree::DAG_Node::XPath' => 0, + 'Tree::DAG_Node::XPath' => '0.10', ; WriteAll; diff --git a/t/01-basic.t b/t/01-basic.t index e947e7a..a8e2474 100644 --- a/t/01-basic.t +++ b/t/01-basic.t @@ -37,9 +37,6 @@ use strict; use warnings; use Tree::DAG_Node::XPath; -sub Tree::DAG_Node::XPath::Root::xpath_get_root_node { return $_[0] } -sub Tree::DAG_Node::XPath::Root::xpath_get_parent_node { return } - my $tree=Tree::DAG_Node::XPath->new(); $tree->name('base'); $tree->new_daughter->name("coso$_") for 1..5; diff --git a/t/02-inherit.t b/t/02-inherit.t index f11d116..e882b53 100644 --- a/t/02-inherit.t +++ b/t/02-inherit.t @@ -41,9 +41,6 @@ use strict; use warnings; use Tree::DAG_Node::XPath; -sub Tree::DAG_Node::XPath::Root::xpath_get_root_node { return $_[0] } -sub Tree::DAG_Node::XPath::Root::xpath_get_parent_node { return } - my $tree=Tree::DAG_Node::XPath->new(); $tree->name('base'); $tree->new_daughter->name("coso$_") for 1..5; diff --git a/t/03-byname.t b/t/03-byname.t index 8c3723f..a16b2d6 100644 --- a/t/03-byname.t +++ b/t/03-byname.t @@ -22,9 +22,6 @@ use strict; use warnings; use Tree::DAG_Node::XPath; -sub Tree::DAG_Node::XPath::Root::xpath_get_root_node { return $_[0] } -sub Tree::DAG_Node::XPath::Root::xpath_get_parent_node { return } - my $tree=Tree::DAG_Node::XPath->new(); $tree->name('base'); $tree->new_daughter->name("coso$_") for 1..5; diff --git a/t/04-errors.t b/t/04-errors.t index ae02713..6656933 100644 --- a/t/04-errors.t +++ b/t/04-errors.t @@ -5,9 +5,6 @@ use strict; use warnings; use Tree::DAG_Node::XPath; -sub Tree::DAG_Node::XPath::Root::xpath_get_root_node { return $_[0] } -sub Tree::DAG_Node::XPath::Root::xpath_get_parent_node { return } - my $tree=Tree::DAG_Node::XPath->new(); $tree->name('base'); $tree->new_daughter->name("coso$_") for 1..5; diff --git a/t/05-html-tree.t b/t/05-html-tree.t index eb990e8..2973d25 100644 --- a/t/05-html-tree.t +++ b/t/05-html-tree.t @@ -18,12 +18,10 @@ package main; use Test::Most 'die'; use strict; use warnings; -eval 'use XML::XPathEngine;use HTML::TreeBuilder::XPath;'; -plan skip_all => 'XML::XPathEngine and HTML::TreeBuilder::XPath needed for this test' if $@; +eval 'use XML::XPathEngine;use HTML::TreeBuilder::XPath 0.10;'; +plan skip_all => 'XML::XPathEngine and HTML::TreeBuilder::XPath 0.10 needed for this test' if $@; plan tests=> 1; -sub HTML::TreeBuilder::XPath::Root::getRootNode { return $_[0] } - my $tree=HTML::TreeBuilder::XPath->new(); $tree->parse(<<'HTML');$tree->eof; diff --git a/t/perlcriticrc b/t/perlcriticrc index 4185498..5ad1ad7 100644 --- a/t/perlcriticrc +++ b/t/perlcriticrc @@ -9,3 +9,4 @@ color = 1 [-Subroutines::RequireArgUnpacking] [-Subroutines::ProtectPrivateSubs] [-ControlStructures::ProhibitUnlessBlocks] +[-CodeLayout::RequireTidyCode] -- cgit v1.2.3