aboutsummaryrefslogtreecommitdiff
path: root/src/evdev.c
Commit message (Collapse)AuthorAge
* Finalize the middle button emulation when a read error occurs (#23048)Peter Hutterer2009-10-19
| | | | | | | | | | | | If a read error occurs, remove the block and wakeup handlers for middle mouse button emulation. Otherwise, they'll still be around after the device has been reopened and overwritten with the new ones created by EvdevOn. Once this happened, future removal of the device can lead to a server crash. X.Org Bug 23048 <http://bugs.freedesktop.org/show_bug.cgi?id=23048> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit f2dc0681febd297d95dae7c9e3ae19b771af8420)
* Only take the driver-internal button mapping to count buttons (#23405)Peter Hutterer2009-08-20
| | | | | | | | | | | | | | | | | | | | Regression: If a user has multiple buttons mapped to the same button number, the number of buttons counted is set to a wrong value. e.g. a button mapping of 1 1 1 for a mouse with three buttons would only initialize 1 button to the X server. In the future, the user cannot change this button mapping as the server only knows about one button. The user-supplied button map (option ButtonMapping) shouldn't matter when counting the buttons. Only the driver-internal mapping (BTN_0 -> button 1, etc.) matters. X.Org Bug 23405 <http://bugs.freedesktop.org/show_bug.cgi?id=23405> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit 415b6ffa958e3103eeb52af4ccd881497169eed4)
* evdev.c: Fix/improve discrimination of rel/abs axesMichael Witten2009-08-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The relevant comment from evdev.c: We don't allow relative and absolute axes on the same device. The reason is that some devices (MS Optical Desktop 2000) register both rel and abs axes for x/y. The abs axes register min/max; this min/max then also applies to the relative device (the mouse) and caps it at 0..255 for both axes. So, unless you have a small screen, you won't be enjoying it much; consequently, absolute axes are generally ignored. However, currenly only a device with absolute axes can be registered as a touch{pad,screen}. Thus, given such a device, absolute axes are used and relative axes are ignored. The code for initializing abs/rel axes has been abstracted out into 3 functions, so that initialization in EvdevInit(device) is as easy as: if (pEvdev->flags & (EVDEV_TOUCHPAD | EVDEV_TOUCHSCREEN)) EvdevInitTouchDevice(device, pEvdev); else if (pEvdev->flags & EVDEV_RELATIVE_EVENTS) EvdevInitRelClass(device, pEvdev); else if (pEvdev->flags & EVDEV_ABSOLUTE_EVENTS) EvdevInitAbsClass(device, pEvdev); Signed-off-by: Michael Witten <mfwitten@gmail.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit f352598e45be86f9e24d9dba88c657f03f3b168e)
* If a device fails to initialize relative axes, init the abs. axes instead.Peter Hutterer2009-07-30
| | | | | | | | | Some devices have relative axes that don't count (scroll wheels). In this case, don't claim we've initialized relative axes, continue with the absolute axes instead. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit b07ab6ea97b779b26e7ae8326528c262cc9907a1)
* evdev: Prevent driver from processing motion events that it has not ↵Derek Upham2009-07-30
| | | | | | | | | | | | | | | configured. #21832 The current implementation initializes itself to support relative motion events, or absolute motion events, or neither. But the event-handling code attempts to process all events, no matter what the initialization was. This patch reproduces the flag tests found during init, to skip events that the driver doesn't support. Signed-off-by: Derek Upham <sand@blarg.net> Signed-off-by: Julien Cristau <jcristau@debian.org> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit 0a3657d2ee62f4086e9687218cb33835ba61a0b3)
* Deal with BTN_3 to BTN_9 buttons.Peter Hutterer2009-07-30
| | | | | | | | | | | | | | These buttons were previously mapped to 0, i.e. inactive. This patch slightly improves things in that the buttons are now mapped to 8+. Devices that have both BTN_3 and BTN_SIDE (or a similar pair in that sequence) have both mapped to the same button number though. Devices that have BTN_LEFT, BTN_0, BTN_3 and BTN_SIDE have the last three mapped to 8 (and their followers have double-mappings too). We'll fix that once we actually see devices affected by this. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit dc2191285e799be891787e1f64d10c1cba271240)
* Only initialize the number of buttons we actually have.Peter Hutterer2009-07-30
| | | | | | | | | This takes into account driver-configured button mappings, i.e. if device with one button has this button mapped to 25 through the ButtonMapping option, the X server will think the device has result 25 buttons. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit 255b9f6bbf374a315750019c6fadc5f82fb7d41d)
* Ensure enough buttons are advertised to pass the button mapping.Peter Hutterer2009-07-30
| | | | | | | | | | | | | | | | | Some buttons are mapped to higher button numbers. For example, BTN_0 is posted as button 8 if BTN_LEFT is present. On top of that, the driver-specific button mapping may map the button to something else again. We need to take these mappings into account when counting the number of buttons on the device. Example: A device with BTN_LEFT and BTN_0 and a mapping from 1 -> 7 and 8 -> 2. BTN_LEFT is mapped to 1. 1 is mapped to 7. num_buttons is 7. BTN_0 is mapped to 8. 8 is mapped to 2. num_buttons remains 7. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit b358f1eb3a4ef8fdee099114d6c70d6ea06eba95)
* Up the number of button labels atoms to EVDEV_MAXBUTTONS.Peter Hutterer2009-07-30
| | | | | | | | | | | | | Button labels would smash memory if the device had less than 4 buttons and did not advertise a wheel event. In this case the hard-coded wheel button labels would write past the atoms[] boundary. Potential memory smash if a device had a BTN_LEFT and BTN_0, since the latter would map to 8, regardless of the the number of actual buttons (same with BTN_MIDDLE and BTN_1 or BTN_RIGHT and BTN_2). Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit 33cc112ca1af377a85cfeb05dfb72f07d3850a95)
* Only label axes and buttons if the device has axes or buttons.Peter Hutterer2009-07-30
| | | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit 3c43d880f13725a04fcd7c0c8d5978a36208e373)
* Print read errors as X_NONE to avoid mallocs in the server.Peter Hutterer2009-04-30
| | | | | | | | | Messages of type X_NONE are just passed down to the log files, everything else gets the (EE) or (II) prefixed. Since this mallocs, we can't use it in the signal handler. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit 220e2dfb8f6aa08bd5f59e81c6883c057b945721)
* Pre-allocate the reopen timer so we don't allocate during sigio handling.Peter Hutterer2009-04-30
| | | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit ddc126637404cb3d9356b7698779dcd8849f8718)
* Trigger read error handling if len is <= 0.Peter Hutterer2009-04-06
| | | | | | | | Red Hat Bug 494245 <https://bugzilla.redhat.com/show_bug.cgi?id=494245> Reported-by: David Woodhouse <dwmw2@infradead.org> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit 98ecb5233bb3b899bd696a90d2733c6a345676dd)
* Fix jumpy touchpads by updating old_vals only when reported by the device.Peter Hutterer2009-03-23
| | | | | | | | | | | Remember whether ABS_X or ABS_Y were reported before the SYN event and only update the old_vals[0, 1] if we got data for them. Touchpads that reported pressure data before x/y would otherwise update old_x/y with bogus values, leading to jumps when the first x/y coordinates were actually reported. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit d9809d7edd2be714a15115b990286554e2979fb6)
* If we have a touchpad, print so, don't claim we're configuring a tablet.Peter Hutterer2009-03-23
| | | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit b11439a1763b5f210460b492dd4f47e973f90a3a)
* make sure to clear all axis_map entriesJeremy Jay2009-03-23
| | | | | | | | don't use uninitialized axis_map entries, ie axis_map[ABS_PRESSURE] Signed-off-by: Jeremy Jay <dinkumator@gmail.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit 740dc202f735106532dce581deabe2b95c52759f)
* Assume touchscreen/touchpad if we have _either_ ABS_PRESSURE or BTN_TOUCHPeter Hutterer2009-03-23
| | | | | | | | Touchpads have pressure or touch and also BTN_TOOL_FINGER. Touchscreens have either pressure or touch, but no finger. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit 7ac0c4456dc0846f7e09f334a26f9536e20065df)
* Set "rel" when converting absolute touchpad coordinates to relative (#20661)Jeremy Jay2009-03-23
| | | | | | | | | | We unset "abs" and convert to relative, but never set "rel" so the events don't get posted. This bit got broken in 43dd2a959243877. X.Org Bug 20661 <http://bugs.freedesktop.org/show_bug.cgi?id=20661> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit a3ea979c2b70d166d62422b4ba450ce2910389c3)
* Restore repeat-filtering for server 1.5 and earlier.Peter Hutterer2009-03-23
| | | | | | | | | | Letting the server deal with key repeats is fine if we have server 1.6. For earlier servers, we need to pass on the repeat events (except for modifier keys). Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Tested-by: Marty Jack <martyj19@comcast.net> (cherry picked from commit a7fb654a68a26ad5f019a902312c6b94dbe9c3ea)
* Check button label before fetching the Atom from the server. (#20524)Peter Hutterer2009-03-09
| | | | | | | | | | The server doesn't like NULL names, so don't call XIGetKnownProperty for labels that don't exist. X.Org Bug 20524 <http://bugs.freedesktop.org/show_bug.cgi?id=20524> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Tested-by: Peter Henriksson
* Fix duplicate wheel button up mapping.Peter Hutterer2009-03-06
| | | | | | | Reported by Simon Thum. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Simon Thum <simon.thum@gmx.de>
* Add support for button labelling.Peter Hutterer2009-03-02
| | | | | | Buttons 4/5 and 6/7 are hardcoded for wheel buttons. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Rename prop_label to prop_axis_label.Peter Hutterer2009-03-02
|
* Don't double-assign the UKNOWN axis label.Peter Hutterer2009-02-26
| | | | | | All labels default to unknown anyway. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* If scrollwheels are found, bump the button number by 4 (or up to 7).Peter Hutterer2009-02-26
| | | | | | | | | | Scrollwheel data is always posted as buttons, so we need to advertise at least enough buttons to accommodate for 6/7 (horizontal wheel). Note that this may mean that if you have a device that has scroll wheels and axes, but no buttons, it may be interpreted as a mouse. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Ignore REL_WHEEL, REL_HWHEEL and REL_DIAL during axis initialisation.Peter Hutterer2009-02-26
| | | | | | We don't post the events for them anyway, so lets ignore them completely. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Pass on all relative events, not just x/y.Peter Hutterer2009-02-26
| | | | | | | | | 9620fe776 added generic axes support for relativ values, but values from such axes didn't get passed on to the server. Fix this. Note that wheel events are not posted as motion events. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Reduce the number of read calls in ReadInput.Adam Jackson2009-02-26
| | | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Adam Jackson <ajax@redhat.com>
* Split ReadInput into ReadInput and ProcessEvent.Peter Hutterer2009-02-26
| | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Move relative motion and other magic up to EV_SYN processing.Adam Jackson2009-02-26
| | | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Adam Jackson <ajax@redhat.com>
* Open with O_NONBLOCK, and simplify EvdevReadInput to match.Adam Jackson2009-02-23
| | | | | | | | | xf86WaitForInput() would call select() with zero timeout to discover if more input was ready. But we know that's always true at least once, since we're only ever called from the sigio handler (if silken is active) or from the main loop (if it's not and we selected readable). With nonblocking IO we can just spin around until we hit EAGAIN, which gets us down to n+1 syscalls per event instead of 2n.
* Label axes conditional on actual support.Peter Hutterer2009-02-18
| | | | | | Server 1.6 has device properties, but not axis labels. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Accommodate for holes in the ABS label defines.Peter Hutterer2009-02-18
| | | | | | | | abs_labels[] has to be aligned with the defines in linux/input.h, but the latter does not have continuous range. Pad the holes with AXIS_LABEL_PROP_ABS_MISC. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Add support for arbitrary relative axis labels.Peter Hutterer2009-02-17
| | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Remove superfluous (and duplicate) call to xf86MotionHistoryAllocate.Peter Hutterer2009-02-17
| | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Add generic axis support for relative axes.Peter Hutterer2009-02-17
| | | | | | Just query the kernel what axes we actually have, rather than hard-coding x/y. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Add dynamic axis labelling for absolute devices.Peter Hutterer2009-02-17
| | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* remove duplicate (code > 255) check.Peter Hutterer2009-02-16
|
* Swap axes after scaling, not before.Peter Hutterer2009-02-16
| | | | | | | | If we swap before scaling, we scale with the wrong coordinate range. Reported by Matt Helsley. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* CacheCompare before probing the device.Peter Hutterer2009-02-16
| | | | | | | | Saves a few duplicate ioctls. Suggested by Matt Helsley. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* General axis valuator support.Matt Helsley2009-02-16
| | | | | | | | | Instead of x/y and pressure, support any absolute axis that is reported on the device. Note that there are still locations that special-case X and Y. Minor modifications by Peter Hutterer. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Change cached bitmasks from long to unsigned long.Peter Hutterer2009-02-16
| | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Log which EVIOCGABS ioctl failed.Peter Hutterer2009-02-16
| | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Remove superfluous motion history allocation.Peter Hutterer2009-02-16
| | | | | | | The motion history buffer is allocated during InitValuatorClassDeviceStruct anyway. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Remove duplicate MB emu finalization.Peter Hutterer2009-02-16
| | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Add descriptive messages for device-has-changed errsBryce Harrington2009-02-13
| | | | | | | | | As can be seen in e.g. bugs 19819 & 20025, it can be unclear what exactly caused a given "Device has changed - disabled" error. This patch adds some more specific messages to give a better clue on what exactly was seen to have changed. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Janitor: make distcheck, .gitignore.Paulo Cesar Pereira de Andrade2009-02-02
| | | | | | | Remove non toplevel .gitignore and .cvsignore files. The "make distcheck correction" for $(sdkdir) probably has a better approach using a "*-hook:" target, or possibly making $sdkdir a configure time option that could be set with DISTCHECK_CONFIGURE_FLAGS.
* EvdevCacheCompare: ignore changes in current device positionJulien Plissonneau Duquene2009-02-03
| | | | | | | | | | | | | Input devices (especially touchscreens) were disabled when switching virtual console back to X because EvdevCacheCompare() thought the device was substituted by another while away from X. Actually only the current position reported by the device changed from what was in the cache. Fixed by ignoring the current position in the comparison. Fixes bug #19819. Signed-off-by: Julien Cristau <jcristau@debian.org> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Stop hammering XKB defaultsDan Nicholson2009-01-29
| | | | | | | | With the new InitKeyboardDeviceStruct, we can just pass the RMLVO we want without setting the defaults first. Signed-off-by: Dan Nicholson <dbn.lists@gmail.com> Signed-off-by: Daniel Stone <daniel@fooishbar.org>
* Reshuffle property initialization.Peter Hutterer2009-01-22
| | | | | | | | | We don't need axis calibration, etc. on keyboards, so let's do it conditionally on actually having axes. Reported by Simon Thum. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
generated by cgit v1.2.3 (git 2.46.0) at 2025-05-01 11:31:10 +0000