aboutsummaryrefslogtreecommitdiff
path: root/src/evdev.c
Commit message (Collapse)AuthorAge
* Report errors when attempting to write keyboard controlsKeith Packard2016-06-02
| | | | | | | This is mostly to eliminate a compiler warning. Signed-off-by: Keith Packard <keithp@keithp.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Restore non-xy axes updatesPeter Hutterer2016-05-12
| | | | | | | | | | | | | This broke in d24431a1863c49aa Restore wheel emulation for absolute devices, last hunk when the valuator update was moved to before any early exit condition. But that new update only applies to valuator maps < 2, i.e. x/y only. Other valuators are now ignored and remain on 0 forever. Restore the valuator update. https://bugs.freedesktop.org/show_bug.cgi?id=95315 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Prevent buffer overrun accessing btn_labelsPeter Hutterer2016-04-27
| | | | | | | | | We go up to BTN_JOYSTICK, hence group can have a value of up to including 15. The actual btn_labels only has 6 elements though. Found by coverity. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Restore wheel emulation for absolute devicesPeter Hutterer2016-01-20
| | | | | | | | | | | | | | | Wheel emulation relies on oldVals, which stopped updating in 3dcf6f123c5. Since wheel emulation may filter the abs event, store the event before we do anything with it. If we really want the abs_event, abs_queued will be set to 1, otherwise the value will be ignored. And now that we know abs_value is always valied, we can copy its value into old_vals, so that wheel emulation can calculate the delta correctly. https://bugs.freedesktop.org/show_bug.cgi?id=93617 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Only map x and y to axes 0 and 1Peter Hutterer2015-11-13
| | | | | | | | | | | | | | | | The Logitech G600 has one device with all axes north of ABS_MISC. The current code assigns ABS_MISC as first axis to map to axis 0, i.e. x. On button press, one node sends the BTN_LEFT but the other node sends an ABS_MISC with a 1 0 value. ABS_MISC is mapped to axis 0, this moves the pointer to (0, y) on every button click. Avoid this by simply mapping any axis other than x/y to at least axis 3, and make sure we only override the MT 0/1 axes when we actually have MT axes. https://bugs.freedesktop.org/show_bug.cgi?id=92856 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Keith Packard <keithp@keithp.com>
* Add "Resolution" option for mice to the evdev driverThomas Hindoe Paaboel Andersen2015-08-27
| | | | | | | | | | | | It can be used to scale the resolution of a mouse to that of a 1000 DPI mouse. This can be useful to make high resolution mice less sensitive without turning off acceleration. The target of 1000 DPI is used as the same default is used in libinput. If the option is not set no scaling will be done. https://bugs.freedesktop.org/show_bug.cgi?id=88134 Signed-off-by: Thomas Hindoe Paaboel Andersen <phomes@gmail.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Always check for a return value on creating a propertyPeter Hutterer2015-03-16
| | | | | | Mostly to make static analyzers happy Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Invert a condition to reduce nestingPeter Hutterer2015-03-13
| | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Disable axis faking and MT event processing on fake MT devicesPeter Hutterer2015-03-11
| | | | | | | | | | | This effectively disables all axes >= ABS_MT_SLOT on those devices. But at least the device comes up without an error and it didn't work correctly beforehand anyway. https://bugs.freedesktop.org/show_bug.cgi?id=89473 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
* Invert two conditions to reduce nestingPeter Hutterer2015-03-11
| | | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
* Factor out MT axis counting into a separate functionPeter Hutterer2015-03-11
| | | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
* Split android axis simulation into a helper functionPeter Hutterer2015-03-11
| | | | | | | No functional changes Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
* Require multitouch/smooth scrolling dependenciesPeter Hutterer2015-03-11
| | | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
* Drop evdev-specific XKB defaultsPeter Hutterer2015-02-13
| | | | | | | Just use the server defaults instead. This has very little effect, on most systems there was some sort of default configuration applied anyway. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Check for incoming MT slot indices exceeding the allocated number of slots.Tobias Himmer2015-01-23
| | | | | | | Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=88715 Signed-off-by: Tobias Himmer <provisorisch@online.de> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Workaround lack of ABS_X on MT devices (#80470)Colin B. Macdonald2014-12-23
| | | | | | | | | Often on Android, we have ABS_MT_POSITION_X without ABS_X (which is contrary to spec). We add fake ABS_X axis in that case. X.Org Bug 80470 <http://bugs.freedesktop.org/show_bug.cgi?id=80470> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Move EVDEV_RELATIVE_MODE logic earlierÉric Brunet2014-12-17
| | | | | | | | | | | | | | | When in EVDEV_RELATIVE_MODE, after converting the absolute valuators, the code unsets pEvdev->abs_queued. This is wrong if there are some absolute valuators which are not positions, such as a pressure valuators, because events on these valuators would be lost. This patch fixes the problem by doing the absolute->relative translation early. This way, abs_queued is not set and then unset when receiving absolute valuators representing positions. Other absolute events now set abs_queued and will be processed. Signed-off-by: Éric Brunet <Eric.Brunet@lps.ens.fr> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Don't update old_vals when not in EVDEV_RELATIVE_MODEÉric Brunet2014-12-17
| | | | | | | | | | When not in EVDEV_RELATIVE_MODE, absolute position is stored in old_vals. This serves no purpose except that old_vals is ready when the device is switched to EVDEV_RELATIVE_MODE. It is however better to make the copy between old_vals and abs_vals at the time of the switch rather than all the time. Signed-off-by: Éric Brunet <Eric.Brunet@lps.ens.fr> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Change the logic concerning EVDEV_RELATIVE_MODE and in_proximityÉric Brunet2014-12-17
| | | | | | | | | | | | | | When not in_proximity, we don't really trust data, even though a valuator sent just before a in_proximity event might actually be important. The present code for EVDEV_RELATIVE_MODE throws away all data if not in_proximity, which is a little bit too much. This patch allows for relative values to be calculated and old_vals to be updated even if not in_proximity, but will prevent evdev to sending (presumably) wrong information to the X server. But at least, old_vals will be correctly filled when the device comes into proximity again. Signed-off-by: Éric Brunet <Eric.Brunet@lps.ens.fr> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* drop the pEvdev->delta arrayÉric Brunet2014-12-17
| | | | | | | | Now that relative events have their own valuator mask, use it instead of delta Signed-off-by: Éric Brunet <Eric.Brunet@lps.ens.fr> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Split pEvdev->vals into pEvdev->abs_vals and pEvdev->rel_valsÉric Brunet2014-12-17
| | | | | | | | This should hopefully fix bug 84445. Signed-off-by: Éric Brunet <Eric.Brunet@lps.ens.fr> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Remove three unused #definesPeter Hutterer2014-11-07
| | | | | | Obsolete since 768c25a99b2f4ec07993eb15a0f05a5e22b5c695 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Don't pass superfluous arguments to EvdevPost*EventsÉric Brunet2014-09-29
| | | | | | | | | | | | The functions EvdevPostProximityEvents, EvdevPostRelativeMotionEvents, EvdevPostAbsoluteMotionEvents and EvdevPostQueuedEvents are only called by EvdevProcessSyncEvent. These functions take as arguments an array of valuators which is set by EvdevProcessSyncEvent to contain ... nothing. This patch changes the prototype of the four functions, their definitions and the way they are called to remove the useless array of valuators. Signed-off-by: Éric Brunet <Eric.Brunet@lps.ens.fr> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Drop some unused #definesPeter Hutterer2014-08-29
| | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* If only IgnoreRelativeAxes is set, init like a normal relative devicePeter Hutterer2014-08-18
| | | | | | | | | | | | In the current code, if only IgnoreRelativeAxes is set, the code would go on and force absolute axes to initialize even if the relative axes were successfully initialized. Evdev gives precedence to relative axes anyway, initializing absolute axes if the relative axes failed. Thus, if we explicitely want relative axes but leave the abs axes as-is, proceed as normal. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Fix axis initialization for devices with abs x/y and rel scrollwheelsPeter Hutterer2014-08-18
| | | | | | | | | | | | | | The Xen Virtual Pointer device has ABS_X, ABS_Y and REL_WHEEL. If smooth scrolling is detected, the current code would first initialize relative axes for scrolling and immediately overwrite those axes when the abs valuators are written out. This patch fixes the default case only, in the case of a device setting the two Ignore*Axis options both to "off", the axes are still overwritten. The wheels will work, other axes only if the same number of abs axes exists. And it keeps the current memory leak too, but it's marked with a FIXME now. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Make the slot-state per slotPeter Hutterer2014-08-18
| | | | | | | | | | | | | | | | | The previous approach only had the slot state for the current slot. If we changed slots, that means we lost the information if the slot was ever initialized. If the ABS_MT_TRACKING_ID was never received, the slot would still update and try to send events (which the server refused with a warning). Avoid this by having a per-slot state and a dirty bit that tells us if the current slot updated at all. If we don't get the tracking ID, leave the slot empty and refuse any further events from that touch. This quashes the various "unable to find touch point 0" warnings caused if a touchpoint starts before the device is enabled. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Walter Harms <wharms@bfs.de>
* Use the server's device list for duplicate detection (#78309)Peter Hutterer2014-05-07
| | | | | | | | | | | | | | | | | | | EvdevAddDevice/EvdevRemoveDevice keep a reference to the device to detect duplicate devices based on the dev_t. EvdevAddDevices was called during PreInit, EvdevRemoveDevice was called during DEVICE_CLOSE. That makes it imbalanced if the device succeeds PreInit but the server skips everything else because MAX_DEVICES is exceeded. So for all devices after MAX_DEVICES, we'd add a reference but never remove it, eventually reading/writing past evdev_devices. The server keeps the list of devices for us anyway, so remove the copy of all the pointers and instead run through the device list the server gives us. X.Org Bug 78309 <http://bugs.freedesktop.org/show_bug.cgi?id=78309> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
* Map REL_DIAL to horizontal scrolling (#73105)Peter Hutterer2014-04-29
| | | | | | | | | | | | | | This was the original behavior introduced in f77410e1f97d394e98c854fd174f712666b0544c and stayed that way until smooth scrolling erroneously added it as vertical axis in b450efdf95999cad08de23ce069f04a66bdae24b. Revert to horizontal scrolling to restore the previous behaviour - which unbreaks scrolling on Microsoft mice. This effectively reverts 54a3120e339e55fc4721543abb15692c3e9ede09 too. X.Org Bug 73105 <http://bugs.freedesktop.org/show_bug.cgi?id=73105> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Revert "Map REL_DIAL to horizontal scrolling (#73105)"Peter Hutterer2014-04-29
| | | | | | | Whoops, the vertical axis is swapped, so when changing the axis we also need to change the direction. This reverts commit 16c85cbeacb721ed365c6240aabaad921b811fe0.
* Map REL_DIAL to horizontal scrolling (#73105)Peter Hutterer2014-04-29
| | | | | | | | | | | | | | | This was the original behavior introduced in f77410e1f97d394e98c854fd174f712666b0544c and stayed that way until smooth scrolling erroneously added it as vertical axis in b450efdf95999cad08de23ce069f04a66bdae24b. Revert to horizontal scrolling to restore the previous behaviour - which unbreaks scrolling on Microsoft mice. This effectively reverts 54a3120e339e55fc4721543abb15692c3e9ede09 too. X.Org Bug 73105 <http://bugs.freedesktop.org/show_bug.cgi?id=73105> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
* evdev: Add support for server managed fdsHans de Goede2014-03-10
| | | | | Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Fix wheel emulation for absolute device (#68415)Peter Hutterer2013-10-22
| | | | | | | | | | | | | wheel emulation, for some reasons beyond time, got the value from pEvdev->vals, then set the value back into pEvdev->vals. Alas, that value is always 0, hence oldValue is zero and the delta is nil. If we're not in relative (touchpad) mode, store the current value in old_vals, so they're retrievable for the next event. X.Org Bug 68415 <http://bugs.freedesktop.org/show_bug.cgi?id=68415> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Export smooth scroll settings as an XInput property.Peter De Wachter2013-10-21
| | | | | | | | | A new property "Evdev Scrolling Distance" is created that holds three values (vertical, horizontal and dial). Signed-off-by: Peter De Wachter <pdewacht@gmail.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Add configuration options for smooth scrolling.Peter De Wachter2013-10-21
| | | | | | | | | | | This patch creates three new xorg.conf options, VertScrollDelta, HorizScrollDelta and DialDelta, which adjust the sensitivity of smooth scrolling. These options take a positive integer, default value is 1. Signed-off-by: Peter De Wachter <pdewacht@gmail.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Use num_slots where appropriatePeter Hutterer2013-10-14
| | | | | | | This was supposed to be added in 43e270fb7a10da20ab89dd699839c1cb6df119b4, but got lost somehow. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Merge branch 'libevdev'Peter Hutterer2013-10-07
|\
| * Use libevdev as backendPeter Hutterer2013-10-04
| | | | | | | | | | | | | | | | | | | | | | | | Removes the need to ioctl manually and check bits, with all the dangers that come with that. libevdev is much better prepared for invalid values, OOB checks, etc. Plus, we get almost free SYN_DROPPED handling as well which we didn't have before. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Adam Jackson <ajax@redhat.com>
| * Use helper function for counting slotsPeter Hutterer2013-09-10
| | | | | | | | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Adam Jackson <ajax@redhat.com>
| * Drop ABS_MT_SLOT minimum - the kernel guarantees a minimum of 0Peter Hutterer2013-09-10
| | | | | | | | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Adam Jackson <ajax@redhat.com>
* | Map REL_DIAL to vertical scrollingPeter De Wachter2013-10-07
|/ | | | | | | | | This makes the absolute axis codepath behave the same as the relative axis path. Signed-off-by: Peter De Wachter <pdewacht@gmail.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Don't use mtdev for protocol B devicesPeter Hutterer2013-08-28
| | | | | | | | | | | If a device has ABS_MT_SLOT, mtdev merely reads the events and returns them to the caller as-is. For this we don't need mtdev, we can just handle those events ourselves. This patch switches to the mtdev plumbing layer that takes events and converts them instead of reading them off the fd. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Write a SYN_REPORT after the last LEDPeter Hutterer2013-08-13
| | | | | | | | | | When writing LED values to the device, append a SYN_REPORT to the list to ensure other clients are updated immediately. Otherwise, the LED events will be queued and not sent to other clients until the next input event arrives. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Daniel Stone <daniel@fooishbar.org>
* Use EvdevBitIsSet, not the server's BitIsOnPeter Hutterer2013-05-31
| | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Drop cached name and led_bitmask - nothing reads thisPeter Hutterer2013-05-31
| | | | | | Both fields are write-only as of xf86-input-evdev-2.5.99.902-1-g1ced7ec Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Switch default model to pc104.Peter Hutterer2013-05-31
| | | | | | | | | | | | | | | | As of xkeyboard-config 1.9, the evdev model is hidden (c887d2876) The server switched to pc105 with version 1.8 (1df4bd601). The evdev model resolves to pc104 anyway, so this commit has no real effect other than to switch from a catch-all rule to explicit. Use pc104 so this is easy to find for those investigating the code and wondering why. pc104 is the 'correct' geometry for the us layout, which is the default after all. Switching to pc105 would show keys missing if no model is set (e.g. on uk/de layouts) but it would be the wrong layout for the default. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Acked-by: Daniel Stone <daniel@fooishbar.org>
* Fail to set up axes for devices that only have MT axes but no ABS_X/Y ↵Peter Hutterer2013-05-01
| | | | | | | | | | | | | | equivalents (#64029) The kernel should give us ABS_X/Y for backwards compat but some devices don't. For now, ignore these devices as evdev is not suited to handle this yet and will crash if a device is set up without axes (i.e. pEvdev->vals == NULL) and later receives an event from an MT axis. X.Org Bug 64029 <http://bugs.freedesktop.org/show_bug.cgi?id=64029> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
* Add option TypeName (#62831)Peter Hutterer2013-04-16
| | | | | | | | | | | | | | | | evdev tries to assign the right XI 1.x type-name based on various device capabilities. In some cases, that fails. e.g. the Mionix Naos 5000 mouse looks like a keyboard. And we assign a keyboard type in that case since there are plenty of keyboards that also advertise some axes or others. Add a new option TypeName to allow for system-wide configuration of such devices in a quirks file. This can also be used to address #55867 X.Org Bug 62831 <http://bugs.freedesktop.org/show_bug.cgi?id=62831> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Return BadValue if EvdevOpenMTDev failsPeter Hutterer2013-02-12
| | | | | | | | | | | | | | FALSE == Success, so if we fail during EvdevOpenMTDev, the caller thinks that everything worked fine, proceeds to set up the fd, etc. This may later cause a crash, when a device comes back later as different device and posts axis events where we didn't configure axes in the first place. Note: Unclear why there was no udev event received for the device being removed and coming back as different device though. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
* Make errors on EVIOCGBIT more obviousPeter Hutterer2013-02-12
| | | | Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-13 00:35:02 +0000